Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: structure align output into www and Offline-HTML dirs #231

Merged
merged 3 commits into from
Jul 15, 2024

Conversation

joanise
Copy link
Member

@joanise joanise commented Jul 12, 2024

PR Goal?

As agreed Wednesday, structure the readalongs align output like the web app's Web Bundle, with www and Offline-HTML subfolders.

Feedback sought?

run align with -o html and confirm you like the results

Priority?

normal

Tests added?

updated existing tests

How to test?

run readalongs align with various output options.

Confidence?

medium-high

Version change?

@joanise joanise marked this pull request as draft July 12, 2024 18:41
@joanise
Copy link
Member Author

joanise commented Jul 12, 2024

Doh, I only fixed some tests. Turning this back into a draft for the moment.

@joanise joanise marked this pull request as ready for review July 12, 2024 20:17
@joanise
Copy link
Member Author

joanise commented Jul 12, 2024

OK, fixed, tests should pass now, this PR is ready to review.

Copy link

codecov bot commented Jul 12, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 87.21%. Comparing base (29ec752) to head (823a2b7).
Report is 1 commits behind head on main.

Files Patch % Lines
readalongs/align.py 81.81% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #231      +/-   ##
==========================================
- Coverage   87.24%   87.21%   -0.04%     
==========================================
  Files          21       21              
  Lines        1772     1783      +11     
  Branches      321      323       +2     
==========================================
+ Hits         1546     1555       +9     
  Misses        189      189              
- Partials       37       39       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

test/test_align_cli.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@deltork deltork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It all looks good!

@joanise
Copy link
Member Author

joanise commented Jul 15, 2024

Improvements pushed, this should be ready to re-review now. Thanks for the review!

@joanise joanise requested a review from deltork July 15, 2024 17:48
Copy link
Collaborator

@deltork deltork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ready

@joanise joanise merged commit 73d2455 into main Jul 15, 2024
6 checks passed
@joanise joanise deleted the dev.ej/bundle-with-offline branch July 15, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants