-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: structure align output into www and Offline-HTML dirs #231
Conversation
Doh, I only fixed some tests. Turning this back into a draft for the moment. |
OK, fixed, tests should pass now, this PR is ready to review. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #231 +/- ##
==========================================
- Coverage 87.24% 87.21% -0.04%
==========================================
Files 21 21
Lines 1772 1783 +11
Branches 321 323 +2
==========================================
+ Hits 1546 1555 +9
Misses 189 189
- Partials 37 39 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It all looks good!
Improvements pushed, this should be ready to re-review now. Thanks for the review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ready
PR Goal?
As agreed Wednesday, structure the
readalongs align
output like the web app's Web Bundle, withwww
andOffline-HTML
subfolders.Feedback sought?
run align with
-o html
and confirm you like the resultsPriority?
normal
Tests added?
updated existing tests
How to test?
run
readalongs align
with various output options.Confidence?
medium-high
Version change?