fix: more places where the current dtd 1.2 version is needed #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These changes are further fixes to #236 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev.del/dtd.patch #238 +/- ##
==================================================
Coverage 87.21% 87.21%
==================================================
Files 21 21
Lines 1783 1783
Branches 323 323
==================================================
Hits 1555 1555
Misses 189 189
Partials 39 39 ☔ View full report in Codecov by Sentry. |
dhdaines
approved these changes
Aug 21, 2024
deltork
added a commit
that referenced
this pull request
Aug 26, 2024
*updated attribute list for <s> to support annotations * feat: RAS format 1.2 * fix(docs): update version in the comment too * ci: verbose output when utf8 on win test fails * fix(test): cs-ref.readalong also needs to current dtd version * fix: more places where the current dtd 1.2 version is needed (#238) --------- Co-authored-by: David Huggins-Daines <[email protected]> Co-authored-by: Eric Joanis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe these additional places need the version bumped to match the latest dtd version too, but I'd like confirmation I'm not misinterpreting anything here.