fix: catch exceptions due to failure to create XML from text #242
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know what causes this, but we got a few 5xx errors from the Heroku logs with this trace:
While it makes no sense we should fail to parse XML we just generated in this broader block:
let's just put a try/except in there since we saw it live on Heroku.
Whatever the error in the input is, though I cannot reproduce it, should generate a 422 HTTP code.
PR Goal?
Fix the 5xx errors we saw on Heroku today.
Feedback sought?
sanity check
Priority?
high
Tests added?
can't reproduce, so none
How to test?
beats me, I can't figure out what caused this to happen on Heroku in the first place.
Confidence?
high, because it's a safe patch: there's no risk in adding a try/except block that should never get triggered.
I still wish I could reproduce it, though, and thus unit test it.
Version change?
no