Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): relax the pydub requirement to allow the latest #244

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

joanise
Copy link
Member

@joanise joanise commented Oct 2, 2024

PR Goal?

The pydub dependency was unduly restrictive, I tested and we're compatible with all more recent versions too.

Feedback sought?

rubber stamping

Priority?

low

Tests added?

matrix test in CI will exercise this

Confidence?

high

Version change?

no

Copy link

Review changes with SemanticDiff.

Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.50%. Comparing base (791e0b9) to head (5f211a4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #244      +/-   ##
==========================================
+ Coverage   87.21%   87.50%   +0.28%     
==========================================
  Files          21       21              
  Lines        1783     1848      +65     
  Branches      323      335      +12     
==========================================
+ Hits         1555     1617      +62     
- Misses        189      192       +3     
  Partials       39       39              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joanise joanise requested review from roedoejet and dhdaines October 2, 2024 12:49
@joanise joanise merged commit 1738c15 into main Oct 3, 2024
8 checks passed
@joanise joanise deleted the dev.ej/relax-pydub branch October 3, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant