Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add run-web-api.sh to easy launch dev mode API server #248

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

joanise
Copy link
Member

@joanise joanise commented Oct 18, 2024

PR Goal?

Stop repeating myself when I want to run the web api, but scripting this command I always have to look up and cut-and-paste!

Fixes?

Simplifies launching the Web API in dev mode.

Feedback sought?

Sanity checking

Priority?

low

Tests added?

n/a

How to test?

Run ./run-web-api.sh, or /path/to/sandboxes/Studio/run-web-api.sh from anywhere, and see the dev web API launched at http://127.0.0.1:8000/api/v1/docs

Confidence?

high

Version change?

no

Copy link

Review changes with SemanticDiff.

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.12%. Comparing base (eec5662) to head (4073d33).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #248      +/-   ##
==========================================
- Coverage   87.51%   87.12%   -0.40%     
==========================================
  Files          21       21              
  Lines        1786     1786              
  Branches      323      323              
==========================================
- Hits         1563     1556       -7     
- Misses        185      191       +6     
- Partials       38       39       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@roedoejet roedoejet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. Works. Looks good to me.

@joanise joanise merged commit 36b8b0d into main Oct 21, 2024
6 checks passed
@joanise joanise deleted the dev.ej/web-api-script branch October 21, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants