Dev.ej/convert to offline html #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OK, not fully PEP 519: I am only doing str or os.PathLike, they say also accept bytes but I see no point in our code base. See https://stackoverflow.com/questions/53418046/how-do-i-type-hint-a-variable-that-can-be-passed-as-the-first-argument-to-open
|
Review changes with Changed Files
|
This was referenced Dec 17, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #256 +/- ##
==========================================
+ Coverage 88.00% 88.06% +0.06%
==========================================
Files 21 21
Lines 1800 1810 +10
Branches 326 327 +1
==========================================
+ Hits 1584 1594 +10
Misses 179 179
Partials 37 37 ☔ View full report in Codecov by Sentry. |
roedoejet
approved these changes
Dec 17, 2024
%s/convert_to_readalong/convert_prealigned_text_to_readalong/g %s/convert_to_offline_html/convert_prealigned_text_to_offline_html/g
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Goal?
Add an API function to convert a sequence of tokens to an Offline HTML file.
Fixes?
Related to EveryVoiceTTS/EveryVoice#439
Feedback sought?
general review and validation
Priority?
EV beta
Tests added?
yup
How to test?
The easiest is to exercise via EV: see EveryVoiceTTS/FastSpeech2_lightning#103
Confidence?
pretty high
Version change?
yeah, we've been adding features, so a minor bump would make sense soon. It'll be required before publishing EV with a requirement on this feature.