Done #201
Open
Done #201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RW locks implemented on databank to ensure thread safety
* Get permissions of a distributor as text or in json format * Validate contract by its structure * Fumigate contract based on parent’s existing permissions * Applying contract upon existing permissions * Proper handling of locking and unlocking (read and write locks used judiciously )
* For ease of testing * init functions removed, and direct call from main.go implemented instead
* Space tolerance * Empty line tolerance * Same region cannot be included and excluded at same time * A region can be excluded only if its parent is included * A region cannot be excluded while including its sub-regions
Effectively, no rate-limit now for testing to make the testing work proper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Validation & Enforcement
• Proper validation of contract syntax, structure, and include-exclude relationships
• Region validation in input data
• Pre-processing contracts based on parent permissions (ignoring entries outside the parent’s scope)
• Constructively applying contracts over existing permissions (if applicable)
✅ Performance & Concurrency Improvements
• Efficient storage & querying using a map-based approach
• Safe thread handling with judicious use of sync.RWMutex to prevent race conditions
• Rate limiting for controlled request handling
✅ Functionality Enhancements
• Fetch permissions in JSON/Text format
• Allow contract submission in text/plain format
✅ Testing & Reliability
• Comprehensive integration testing to ensure correctness
⸻
📝 Authored by: Abdul Rahim O M
📧 Contact: [email protected]
🎥 Walkthrough Video: YouTube Link
🔗 Postman API Collection: Postman API Link
📖 Postman Documentation: Postman API Documentation