Remove FLAC bit depth in output folder name #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll be revisiting this as I set up testing ; the idea is solid, but I want to be confident the execution won't mangle folder names. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed a lot of folders seem to have bit depth information in them (e.g. "16-48 FLAC"), so often this script will produce folders with names like "... [16-48 320]" which doesn't seem right. I changed the regex to catch as many cases as I could find, although this may break if the year or catalog number ends with 16/24 and is only separated by the string "FLAC" with a space.
Let me know if this is helpful. Maybe make it a CLI option?