Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Access Control] Fix performance issues with Redis SCAN #105

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JulienDuf
Copy link
Member

The default page size of a scan is small, 10 with my current setup.

This can cause performance issues with large Redis Databases, it will create a lot of iteration with the cursor. In some cases, it more performant to process larger pages.

@JulienDuf JulienDuf requested a review from Jtplouffe January 18, 2024 17:16
Copy link
Contributor

@Jtplouffe Jtplouffe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think 10k might be too much, we should probably consider something like 500 or 1000, otherwise it may block the redis server for too long, and may stack up pending commends
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants