-
-
Notifications
You must be signed in to change notification settings - Fork 1k
Server Side Events - SSE #386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… num with 11 chars
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces Server-Sent Events (SSE) functionality to the Red5 server, providing W3C-compliant real-time server-to-client communication capabilities. The implementation integrates seamlessly with Red5's existing Tomcat servlet infrastructure and includes comprehensive SSE management features.
- Complete SSE implementation with connection management, event broadcasting, and scope integration
- Updated logging framework from Red5LoggerFactory to standard slf4j LoggerFactory across multiple classes
- Version bump from 2.0.22 to 2.0.23 across all modules
Reviewed Changes
Copilot reviewed 46 out of 46 changed files in this pull request and generated 6 comments.
Show a summary per file
File | Description |
---|---|
SSE-README.md | Comprehensive documentation for the new SSE feature implementation |
server/src/main/java/org/red5/server/net/sse/*.java | Core SSE implementation including servlet, manager, service, and connection classes |
server/src/main/java/org/red5/server/adapter/SSEApplicationAdapter.java | Application adapter with built-in SSE integration for Red5 applications |
server/src/main/server/webapps//sse-.html | Test pages demonstrating SSE functionality |
server/src/main/server/webapps/live/WEB-INF/web.xml | Servlet configuration for SSE endpoint |
server/src/main/server/conf/*.xml | Spring configuration for SSE beans and Tomcat loader setup |
Multiple *.java files | Logging framework migration from Red5LoggerFactory to LoggerFactory |
*/pom.xml | Version updates and dependency scope changes |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
server/src/main/java/org/red5/server/adapter/SSEApplicationAdapter.java
Outdated
Show resolved
Hide resolved
…pter.java Co-authored-by: Copilot <[email protected]>
Refactor cleanupStaleConnections to use a list for removals.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 38 out of 38 changed files in this pull request and generated 5 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
SSE feature
Testing WAR can be located here: https://github.com/Red5/red5-websocket-chat/releases/tag/v2.0.23
Server-Sent Events (SSE) is a server-push technology that allows a server to automatically send real-time updates to a browser client over a single, long-lived HTTP connection. Unlike WebSockets, SSE is primarily for one-way communication (server to client), making it ideal for applications needing steady updates such as live data feeds, notifications, or chat applications without requiring two-way interaction. The browser uses the EventSource API to establish and maintain the connection, which includes features like automatic reconnection.
Most of the file changes are due to the older Red5LoggerFactory use vs LoggerFactory from sl4j.