Skip to content

Conversation

mondain
Copy link
Member

@mondain mondain commented Sep 20, 2025

SSE feature

Testing WAR can be located here: https://github.com/Red5/red5-websocket-chat/releases/tag/v2.0.23

Server-Sent Events (SSE) is a server-push technology that allows a server to automatically send real-time updates to a browser client over a single, long-lived HTTP connection. Unlike WebSockets, SSE is primarily for one-way communication (server to client), making it ideal for applications needing steady updates such as live data feeds, notifications, or chat applications without requiring two-way interaction. The browser uses the EventSource API to establish and maintain the connection, which includes features like automatic reconnection.

Most of the file changes are due to the older Red5LoggerFactory use vs LoggerFactory from sl4j.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces Server-Sent Events (SSE) functionality to the Red5 server, providing W3C-compliant real-time server-to-client communication capabilities. The implementation integrates seamlessly with Red5's existing Tomcat servlet infrastructure and includes comprehensive SSE management features.

  • Complete SSE implementation with connection management, event broadcasting, and scope integration
  • Updated logging framework from Red5LoggerFactory to standard slf4j LoggerFactory across multiple classes
  • Version bump from 2.0.22 to 2.0.23 across all modules

Reviewed Changes

Copilot reviewed 46 out of 46 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
SSE-README.md Comprehensive documentation for the new SSE feature implementation
server/src/main/java/org/red5/server/net/sse/*.java Core SSE implementation including servlet, manager, service, and connection classes
server/src/main/java/org/red5/server/adapter/SSEApplicationAdapter.java Application adapter with built-in SSE integration for Red5 applications
server/src/main/server/webapps//sse-.html Test pages demonstrating SSE functionality
server/src/main/server/webapps/live/WEB-INF/web.xml Servlet configuration for SSE endpoint
server/src/main/server/conf/*.xml Spring configuration for SSE beans and Tomcat loader setup
Multiple *.java files Logging framework migration from Red5LoggerFactory to LoggerFactory
*/pom.xml Version updates and dependency scope changes

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Refactor cleanupStaleConnections to use a list for removals.
@mondain mondain requested a review from Copilot September 27, 2025 05:58
@mondain mondain merged commit a63d961 into main Sep 27, 2025
@mondain mondain deleted the sse branch September 27, 2025 05:59
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 38 out of 38 changed files in this pull request and generated 5 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant