-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dockerfile simplification #10
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
- Adds package repo to yum without
yum-utils
- Same repo found in the upstream Dockerfile
- Replace
git
package with git-core - Disable Weak Dependencies
@dagbay-rh @casey-williams-rh how to proceed? I mean who can run awaiting workflows? how this works? thank you |
The error preventing the image from building is:
The problem is caused by the conflict between openresty-resty version 1.19.3 which is explicitly required in the Dockerfile and newer version of one dependency openresty-1.21.4 which is not required explicitly and therefore installed in the newest possible version. I pushed the fix which pins the same version of openresty. |
Can one of the admins verify this patch? |
I think my merging of the upstream repo created conflicts.... sorry 😿 |
e1b2051
to
593d4dd
Compare
Rebased |
When talking about your Dockefile this morning with @petracihalova, we realized that it might be simplified.