Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ansible namespace support flow #539

Merged

Conversation

Hyperkid123
Copy link
Contributor

Jira: https://issues.redhat.com/browse/RHCLOUD-32338

In addition to the required changes, I've also done some extra stuff. Let me know if you want to split it into a different PR

  • added some notes when using the apple M chip, the usual project init did not work for me and some extra stuff had to be added
  • also started using images for postgres from quay, because of docker hub rate limiting

Docker is ratelimiting the RH network. It happesn quite often in the office on the VPN network
@tahmidefaz
Copy link
Member

@Hyperkid123 Looking good!
I'd recommend the following:

  • Add a test for the flow. Some examples: Here
  • Saw a number of steps missing from what we have on Miro. Any reason why?

@justinorringer
Copy link
Contributor

* Saw a number of steps missing from what we have on Miro. Any reason why?

Looks like they canned the fun one (its half baked anyway). He chose the right one

Copy link
Contributor

@justinorringer justinorringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for wading through the mac nonsense

- unable to get to my ansible namespace
- i used to be able to access my ansible namespace but i can't anymore
- are you able to get me access to a ansible namespace
- it says i don't have access to my ansible namespace
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- it says i don't have access to my ansible namespace
- it says i don't have access to my ansible namespace
- ansible namespace access
- ansible namespace issues
- ansible namespace problems
- ansible namespace doesn't work
- how do I get access to an ansible namespace
- fix ansible namespace

Our bot is dumb, some more examples

slots: {}

responses:
utter_inform_reach_out_to_support:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
utter_inform_reach_out_to_support:
utter_ansible_inform_reach_out_to_support:

Just want to scope these. I don't know we would manage to duplicate the name elsewhere, but you never know

- rule: Reach out to support
steps:
- intent: intent_ansible_namespaces_access_issues
- action: utter_inform_reach_out_to_support
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- action: utter_inform_reach_out_to_support
- action: utter_ansible_inform_reach_out_to_support

@Hyperkid123
Copy link
Contributor Author

@tahmidefaz @justinorringer Thanks for checking this over. I'll update the config files.

And yeah I was a bit confused about the missing actions. I am glad that I did not misrepresent the miro board.

@tahmidefaz
Copy link
Member

* Saw a number of steps missing from what we have on Miro. Any reason why?

Looks like they canned the fun one (its half baked anyway). He chose the right one

Why would they keep it there if they deprecated it... 🤦
Thank you for pointing it out!

@justinorringer justinorringer merged commit a1395e7 into RedHatInsights:main Sep 23, 2024
10 of 13 checks passed
@Hyperkid123 Hyperkid123 deleted the ansible-namespace-support-flow branch September 24, 2024 07:28
@Hyperkid123 Hyperkid123 restored the ansible-namespace-support-flow branch September 24, 2024 07:28
@Hyperkid123 Hyperkid123 deleted the ansible-namespace-support-flow branch September 24, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants