Add delete endpoint for portfolio_item #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
cc - @lgalis |
mkanoor
reviewed
Jan 7, 2019
| delete "/api/v0.0/portfolio_items/#{portfolio_item_id}", :headers => admin_headers, :params => valid_attributes | ||
| end | ||
|
|
||
| it 'deletes the record' do |
There was a problem hiding this comment.
@syncrou Do we need a TODO to add a test as a non admin user it should fail. Since we don't have any constraints check now we would have to wait. Also a GitHub issue might help
There was a problem hiding this comment.
Added a TODO that points to this Issue: #85
mkanoor
reviewed
Jan 7, 2019
| parameters: | ||
| - $ref: '#/parameters/PortfolioItemID' | ||
| responses: | ||
| 204: |
There was a problem hiding this comment.
@syncrou The 204 status reads
The HTTP 204 No Content success status response code indicates that the request has succeeded, but that the client doesn't need to go away from its current page
@lgalis Is the UI going to react properly for a 204, it would have to issue a refresh of the portfolio items page
syncrou
force-pushed
the
only_delete_portfolio_items
branch
from
51e8289
to
1786516
Compare
|
@syncrou - looks good |
gmcculloug
approved these changes
Jan 7, 2019
mkanoor
approved these changes
Jan 7, 2019
gmcculloug
pushed a commit
to gmcculloug/catalog-api
that referenced
this pull request
Nov 8, 2019
Use PF4 data list to show orders.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.