Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(serviceConfig): squash flake, reduce polling interval #1459

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Oct 25, 2024

What's included

  • test(serviceConfig): squash flake, reduce polling interval

Notes

  • a flake seems to be popping up more recently around the polling config tests, attempt to squash it by reducing the test poll interval
    • this isn't the only repo where we seem to have new flakes with github actions popping up. currently, it seems to correlate with the lesser node version if there are multiples... probably more to do with it running first

How to test

  • attempt to randomly re-run both node github actions throughout a week. and randomly reset the cache associated with the pr

Example

...

Updates issue/story

ongoing

@cdcabrera cdcabrera added the 202412 project phase label Oct 25, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.48%. Comparing base (e879427) to head (347141b).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1459   +/-   ##
=======================================
  Coverage   91.48%   91.48%           
=======================================
  Files         115      115           
  Lines        4637     4637           
  Branches     2054     2054           
=======================================
  Hits         4242     4242           
  Misses        369      369           
  Partials       26       26           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e879427...347141b. Read the comment docs.

@cdcabrera cdcabrera merged commit 28835cd into RedHatInsights:main Oct 28, 2024
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202412 project phase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants