updates: implement inventoryGroupDevicesInfo #2304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldjebran
requested review from
maxamillion,
acosferreira,
loadtheaccumulator,
AaronH88,
thom-at-redhat,
mgold1234,
tomershinhar,
de1987,
omaciel and
lahavyuv86
as code owners
ldjebran
force-pushed
the
implement-inventory-group-devices-update-info
branch
from
d07828a to
f5c5f82
Compare
mgold1234
reviewed
Nov 15, 2023
|
This pull request needs all conversation threads to be resolved. Could you fix it @ldjebran? 🙏 |
mergify
bot
added
question
|
This pull request is now in conflicts. Could you fix it @ldjebran? 🙏 |
ldjebran
force-pushed
the
implement-inventory-group-devices-update-info
branch
from
f5c5f82 to
d162fdc
Compare
mergify
bot
dismissed
acosferreira’s stale review
New commit(s) added, removing existing approval(s)
acosferreira
previously approved these changes
Nov 15, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2304 +/- ##
==========================================
+ Coverage 62.20% 62.36% +0.16%
==========================================
Files 86 86
Lines 12842 12942 +100
==========================================
+ Hits 7988 8071 +83
- Misses 4194 4206 +12
- Partials 660 665 +5 ☔ View full report in Codecov by Sentry. |
In the context of inventory group details view we want to update devices of an inventory group. But before that we to need to retrieve validation data and the device uuids related to this group. FIXES: https://issues.redhat.com/browse/THEEDGE-3539
ldjebran
force-pushed
the
implement-inventory-group-devices-update-info
branch
from
d162fdc to
61e905d
Compare
mergify
bot
dismissed
acosferreira’s stale review
New commit(s) added, removing existing approval(s)
acosferreira
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the context of inventory group details view we want to update devices of an inventory group. But before that we to need to retrieve validation data and the device uuids related to this group.
FIXES: https://issues.redhat.com/browse/THEEDGE-3539
Type of change
What is it?
Checklist:
make pre-committo check fmt/vet/lint/test-no-fdo