rbac: implement rbac client #2310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldjebran
requested review from
maxamillion,
acosferreira,
loadtheaccumulator,
AaronH88,
thom-at-redhat,
mgold1234,
tomershinhar,
de1987,
omaciel and
lahavyuv86
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2310 +/- ##
==========================================
+ Coverage 62.38% 62.47% +0.08%
==========================================
Files 86 87 +1
Lines 12949 12979 +30
==========================================
+ Hits 8078 8108 +30
Misses 4206 4206
Partials 665 665 ☔ View full report in Codecov by Sentry. |
ldjebran
force-pushed
the
rbac-client
branch
4 times, most recently
from
433bc73 to
e3c73b6
Compare
|
This pull request needs all conversation threads to be resolved. Could you fix it @ldjebran? 🙏 |
because the insights rbac client use other Filter Data type, we need to reimplement the rbac client for inventory needs. FIXES: https://issues.redhat.com/browse/THEEDGE-3624 FIXES: https://issues.redhat.com/browse/THEEDGE-3734
ldjebran
force-pushed
the
rbac-client
branch
from
e3c73b6 to
ca55a31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Because the insights rbac client use other Filter Data type, we need to reimplement the rbac client for inventory needs.
run go mod tidy to remove any unused lib
FIXES: https://issues.redhat.com/browse/THEEDGE-3624
FIXES: https://issues.redhat.com/browse/THEEDGE-3734
Type of change
What is it?
Checklist:
make pre-committo check fmt/vet/lint/test-no-fdo