Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

device-group-view: add enforce-edge-groups #2317

Conversation

ldjebran
Copy link
Contributor

Description

when an org is enforced to use edge-groups the edge groups was not displayed inventory group was displayed instead. this fix this behavior.

FIXES: https://issues.redhat.com/browse/THEEDGE-3552

Type of change

What is it?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation update
  • Tests update
  • Refactor

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I run make pre-commit to check fmt/vet/lint/test-no-fdo

when an org is enforced to use edge-groups the edge groups was not displayed inventory group was displayed instead. this fix this behavior.

FIXES: https://issues.redhat.com/browse/THEEDGE-3552
Copy link
Contributor

@omaciel omaciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@mergify mergify bot merged commit ad865f3 into RedHatInsights:main Nov 24, 2023
6 checks passed
@mergify mergify bot added the waiting for review Need reviewers label Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix Fixes #issue waiting for review Need reviewers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants