Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kafka: use clowder KafkaServers #2318

Merged
merged 2 commits into from
Nov 27, 2023

Conversation

ldjebran
Copy link
Contributor

Description

To allow multi kafka servers usage, use clowder KafkaServers.

FIXES: https://issues.redhat.com/browse/THEEDGE-3708

Type of change

What is it?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation update
  • Tests update
  • Refactor

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I run make pre-commit to check fmt/vet/lint/test-no-fdo

To allow multi kafka servers usage, use clowder KafkaServers.

FIXES: https://issues.redhat.com/browse/THEEDGE-3708
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ad865f3) 62.72% compared to head (6f1bf74) 62.72%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2318   +/-   ##
=======================================
  Coverage   62.72%   62.72%           
=======================================
  Files          87       87           
  Lines       12985    12986    +1     
=======================================
+ Hits         8145     8146    +1     
  Misses       4169     4169           
  Partials      671      671           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@omaciel omaciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@mergify mergify bot added the waiting for review Need reviewers label Nov 25, 2023
@mergify mergify bot merged commit ffb0f67 into RedHatInsights:main Nov 27, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature waiting for review Need reviewers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants