Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrategroups: update migrate groups #2329

Merged
merged 1 commit into from
Dec 14, 2023
Merged

migrategroups: update migrate groups #2329

merged 1 commit into from
Dec 14, 2023

Conversation

ldjebran
Copy link
Contributor

@ldjebran ldjebran commented Dec 5, 2023 •
edited
Loading

Description

Update migrate groups

  1. Update User identity type and orgAdmin value (fixes RBAC issue)
  2. Remove default org filters
  3. Add support for wildcard groups filtring.
  4. Query inventory for group hosts to ensure existence and no other group inclusion
  5. Ignor group migration if the group already exist in inventory groups
  6. Skip migration of organizations with feature flag enforce-edge-groups ON
  7. Ensure orgs are not processed twice because of some groups not migrated
  8. Update unit-tests

FIXES: https://issues.redhat.com/browse/THEEDGE-3555

Type of change

What is it?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation update
  • Tests update
  • Refactor

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I run make pre-commit to check fmt/vet/lint/test-no-fdo

@mergify mergify bot added the new feature New feature label Dec 5, 2023
@ldjebran ldjebran force-pushed the update-migrategroups branch from 349d561 to 4c72ad8 Compare December 6, 2023 13:29
@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2023 •
edited
Loading

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (f5bb4a8) 62.70% compared to head (16f6081) 62.85%.

Files Patch % Lines
cmd/migrategroups/migrategroups/migrategroups.go 98.55% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2329      +/-   ##
==========================================
+ Coverage   62.70%   62.85%   +0.14%     
==========================================
  Files          87       87              
  Lines       12985    13029      +44     
==========================================
+ Hits         8142     8189      +47     
+ Misses       4171     4169       -2     
+ Partials      672      671       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mergify mergify bot added the waiting for review Need reviewers label Dec 6, 2023
adeliaferreira
adeliaferreira approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@adeliaferreira adeliaferreira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

mgold1234
mgold1234 approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@mgold1234 mgold1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

omaciel
omaciel reviewed Dec 14, 2023
View reviewed changes
Copy link
Contributor

@omaciel omaciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm reaching out on Slack for some topics.

cmd/migrategroups/migrategroups/migrategroups.go Show resolved Hide resolved
cmd/migrategroups/migrategroups/migrategroups.go Outdated Show resolved Hide resolved
cmd/migrategroups/migrategroups/migrategroups.go Show resolved Hide resolved
cmd/migrategroups/migrategroups/migrategroups.go Show resolved Hide resolved
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 14, 2023

This pull request needs all conversation threads to be resolved. Could you fix it @ldjebran? 🙏

@mergify mergify bot added question Further information is requested and removed waiting for review Need reviewers labels Dec 14, 2023
@ldjebran
migrategroups: update migrate groups
16f6081 
Update migrate groups
1. Update User identity type and orgAdmin value
2. Remove default org filters
3. Add support for wildcard groups filtring.
4. Query inventory for group hosts to ensure existence and no other group inclusion
5. Ignor group migration if the group already exist in inventory groups
6. Skip migration of organizations with feature flag enforce-edge-groups ON
7. Ensure orgs are not processed twice because of some groups not migrated
8. Update unit-tests

FIXES: https://issues.redhat.com/browse/THEEDGE-3555
@ldjebran ldjebran force-pushed the update-migrategroups branch from 37b40d5 to 16f6081 Compare December 14, 2023 15:37
omaciel
omaciel approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@omaciel omaciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@mergify mergify bot removed the question Further information is requested label Dec 14, 2023
@mergify mergify bot merged commit 3d2a34e into RedHatInsights:main Dec 14, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgold1234 mgold1234 mgold1234 approved these changes

@adeliaferreira adeliaferreira adeliaferreira approved these changes

@omaciel omaciel omaciel approved these changes

@maxamillion maxamillion Awaiting requested review from maxamillion

@acosferreira acosferreira Awaiting requested review from acosferreira

@loadtheaccumulator loadtheaccumulator Awaiting requested review from loadtheaccumulator loadtheaccumulator is a code owner

@AaronH88 AaronH88 Awaiting requested review from AaronH88

@thom-at-redhat thom-at-redhat Awaiting requested review from thom-at-redhat

@tomershinhar tomershinhar Awaiting requested review from tomershinhar

@de1987 de1987 Awaiting requested review from de1987

@lahavyuv86 lahavyuv86 Awaiting requested review from lahavyuv86

Assignees
No one assigned
Labels
new feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ldjebran @codecov-commenter @omaciel @adeliaferreira @mgold1234