Merge pull request #208 from hsong-rh/fix_error_logs

Fixed to log error messages in with_request block

lib/insights/api/common/application_controller_mixins/exception_handling.rb

@@ -14,7 +14,6 @@ def self.included(other)
           end
 
           def rescue_from_handler(exception)
-            logger.error("#{exception.class.name}: #{exception.message}\n#{exception.backtrace.join("\n")}")
             errors = Insights::API::Common::ErrorDocument.new.tap do |error_document|
               exception_list_from(exception).each do |exc|
                 if api_client_exception?(exc)

lib/insights/api/common/request.rb

@@ -57,6 +57,9 @@ def self.with_request(request)
           self.current = request
           self.current_request_id = current&.request_id
           yield current
+        rescue => exception
+          Rails.logger.error("#{exception.class.name}: #{exception.message}\n#{exception.backtrace.join("\n")}")
+          raise
         ensure
           self.current = saved
           self.current_request_id = saved_request_id

spec/lib/insights/api/common/request_spec.rb

@@ -200,6 +200,8 @@
     end
 
     it 'with an invalid Hash' do
+      expect(Rails.logger).to receive(:error).with(/ArgumentError: /).once
+
       expect do
         described_class.with_request({}) {}
       end.to raise_exception(ArgumentError)