Fix user access location in settings icon #2958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karelhala
requested review from
Hyperkid123,
ryelo and
florkbr
as code owners
|
/retest |
fhlavac
approved these changes
Oct 22, 2024
Hyperkid123
requested changes
Oct 22, 2024
src/components/Header/Tools.tsx
Outdated
| @@ -75,8 +75,10 @@ const Tools = () => { | |||
| const unreadNotifications = useAtomValue(unreadNotificationsAtom); | |||
| const [isNotificationDrawerExpanded, toggleNotifications] = useAtom(notificationDrawerExpandedAtom); | |||
| const intl = useIntl(); | |||
| const auth = useContext(ChromeAuthContext); | |||
There was a problem hiding this comment.
This context is already called in the component.
There was a problem hiding this comment.
Ah, good point! Solved.
karelhala
force-pushed
the
fix-user-access-setting
branch
from
4ca3535
to
4aede38
Compare
Hyperkid123
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As a regular user when I click on settings icon I should be brought to my user access. However as an org admin user should be brought to user access.
This PR adjusts the title and link.
JIRA
RHCLOUD-33599