feat: collect AWS public IPv4 as cannonical fact #3732
Conversation
ezr-ondrej
force-pushed
the
add_aws_public_ip
branch
from
3d8430d
to
40c16f7
Compare
| facts = dict( | ||
| insights_id=valid_uuid_or_None(_safe_parse(insights_id)), | ||
| machine_id=valid_uuid_or_None(_safe_parse(machine_id)), | ||
| bios_uuid=valid_uuid_or_None(_safe_parse(bios_uuid)), | ||
| subscription_manager_id=valid_uuid_or_None(submanid.data if submanid else None), | ||
| ip_addresses=ips.data if ips else [], | ||
| ip_addresses=ips_list, |
There was a problem hiding this comment.
The canonical facts JSON schema is not (to my knowledge) strictly defined anywhere, but it is assumed to include a certain set of keys (in other words, it follows a de facto standard). There are other implementations in code that (for instance, rhc and in cloud-connector) that assume the current schema is adhered to. I suggest you take care when making changes to canonical facts. This change is safe, since you don't appear to be altering the key strings at all, but the above history of canonical facts is important to keep in mind.
There was a problem hiding this comment.
FYI, here's the list of canonical facts: https://consoledot.pages.redhat.com/docs/dev/services/inventory.html#_host_deduplication
There was a problem hiding this comment.
I think the intention was not to modify canonical facts, this looks like a copy and paste mistake. From what I understand, AWS/Azure/GCP id and types are present here because they provide a good value for host identity, these are unique idents. Our use case is different tho - we want to report a public IP address which can very often change, for example when user shutdowns and starts an instance again (a new public IP is assigned) or it can be even manually reconfigured by user.
Therefore we only want to register the new datasource and send it along with other facts. This is done via RegistryPoint() function if I understand correctly.
|
@ezr-ondrej - This PR added a new Spec to the core collection, for any new specs, it's required to get it approved before collecting it. Could you please go to the insights-core-assets Gitlab repo to get it approved? I added the link of the repo to the ESSNTL-4588, please have a look. |
|
@ezr-ondrej can you close this one in fav of: #3741 I am taking over, thanks! |
|
Happy to, thanks for taking over 🧡 |
All Pull Requests:
Check all that apply:
Complete Description of Additions/Changes:
This tries to add an AWS public IP address, that is not known to the machine itself.
Issue: #3731
Refs ESSNTL-4588
This is yet a draft, I'd love to hear if my approach would work here, so far I've pulled just IP as it's easier do demonsrate and agree upon my intended approach :)