Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Azure public IP spec #3751

Merged
merged 0 commits into from
Apr 19, 2023
Merged

feat: Azure public IP spec #3751

merged 0 commits into from
Apr 19, 2023

Conversation

lzap
Copy link
Contributor

@lzap lzap commented Apr 14, 2023

All Pull Requests:

Check all that apply:

  • Have you followed the guidelines in our Contributing document, including the instructions about commit messages?
  • Is this PR to correct an issue?
  • Is this PR an enhancement?

Complete Description of Additions/Changes:

This patch adds Azure public IP address:

Refs ESSNTL-4679

Related to: #3741

Test on an Azure instance:

# BYPASS_GPG=true EGG=/root/insights.zip insights-client --offline --no-upload --keep-archive --no-gpg

# cat insights-lzap-insights-client.bke4gskh30hejcgg4rxro51k3g.bx.internal.cloudapp.net-20230414121920/meta_data/insights.specs.Specs.azure_load_balancer.json | jq
{
  "name": "insights.specs.Specs.azure_load_balancer",
  "exec_time": 0.0001773834228515625,
  "errors": [],
  "results": {
    "type": "insights.core.spec_factory.CommandOutputProvider",
    "object": {
      "rc": null,
      "cmd": "/usr/bin/curl -s -H Metadata:true http://169.254.169.254/metadata/loadbalancer?api-version=2021-12-13&format=json --connect-timeout 5",
      "args": null,
      "relative_path": "insights_commands/curl_-s_-H_Metadata_true_http_..169.254.169.254.metadata.loadbalancer_api-version_2021-12-13_format_json_--connect-timeout_5"
    }
  },
  "ser_time": 0.017719268798828125
}

# cat insights-lzap-insights-client.bke4gskh30hejcgg4rxro51k3g.bx.internal.cloudapp.net-20230414121920/data/insights_commands/curl_-s_-H_Metadata_true_http_..169.254.169.254.metadata.loadbalancer_api-version_2021-12-13_format_json_--connect-timeout_5 | jq
{
  "loadbalancer": {
    "publicIpAddresses": [
      {
        "frontendIpAddress": "137.116.118.209",
        "privateIpAddress": "10.0.0.4"
      }
    ],
    "inboundRules": [],
    "outboundRules": []
  }
}

Not sure how to actually test spec parsing.

@xiangce xiangce merged commit fabc9cb into RedHatInsights:master Apr 19, 2023
xiangce pushed a commit that referenced this pull request Apr 19, 2023
Signed-off-by: Lukas Zapletal <[email protected]>
(cherry picked from commit fabc9cb)
@lzap lzap deleted the azure-spec branch April 20, 2023 13:45
xiangce pushed a commit that referenced this pull request Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants