feat: Google Cloud public IP spec #3762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lzap
force-pushed
the
gcp-spec
branch
3 times, most recently
from
c6a5018
to
01d1f38
Compare
xiangce
reviewed
Apr 25, 2023
xiangce
approved these changes
Apr 25, 2023
|
Sure, I added the single quotes, I was not sure but it looked like these commands are executed via shell and there is a question mark. Thank you! |
xiangce
pushed a commit
that referenced
this pull request
Apr 26, 2023
Signed-off-by: Lukas Zapletal <[email protected]> (cherry picked from commit 2dcf9a8)
xiangce
pushed a commit
that referenced
this pull request
Sep 6, 2024
Signed-off-by: Lukas Zapletal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Pull Requests:
Check all that apply:
Complete Description of Additions/Changes:
This patch adds Azure public IP address:
Refs https://issues.redhat.com/browse/ESSNTL-4680
Related to: #3741
I am going to do an end-to-end test on GCP shortly.