Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 2 new properties to OSRelease combiner #3863

Merged
merged 0 commits into from
Aug 1, 2023
Merged

feat: 2 new properties to OSRelease combiner #3863

merged 0 commits into from
Aug 1, 2023

Conversation

xiangce
Copy link
Contributor

@xiangce xiangce commented Jul 31, 2023

  • "name" to return the NAME of '/etc/os-release'
  • "is_rhel_compatible" to return if convert2rhel could convert

All Pull Requests:

Check all that apply:

  • Have you followed the guidelines in our Contributing document, including the instructions about commit messages?
  • Is this PR to correct an issue?
  • Is this PR an enhancement?

@kami-nashi
Copy link

This looks like what we discussed, i think its going to do what we need and I'll try to see what I can do about the failing tests today.

@xiangce xiangce merged commit 8a7e06c into master Aug 1, 2023
7 checks passed
@xiangce xiangce deleted the en_os_release branch August 1, 2023 02:56
xiangce added a commit that referenced this pull request Aug 2, 2023
- "name": return the NAME of '/etc/os-release'
- "is_rhel_compatible": return if convert2rhel could convert

Signed-off-by: Xiangce Liu <[email protected]>
(cherry picked from commit 8a7e06c)
xiangce added a commit that referenced this pull request Sep 6, 2024
- "name": return the NAME of '/etc/os-release'
- "is_rhel_compatible": return if convert2rhel could convert

Signed-off-by: Xiangce Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants