Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't redact ls_systemd_units to avoid issue#3858 #3870

Merged
merged 0 commits into from
Aug 3, 2023
Merged

fix: don't redact ls_systemd_units to avoid issue#3858 #3870

merged 0 commits into from
Aug 3, 2023

Conversation

xiangce
Copy link
Contributor

@xiangce xiangce commented Aug 3, 2023 •
edited
Loading

All Pull Requests:

Check all that apply:

  • Have you followed the guidelines in our Contributing document, including the instructions about commit messages?
  • Is this PR to correct an issue?
  • Is this PR an enhancement?

Complete Description of Additions/Changes:

@xiangce xiangce mentioned this pull request Aug 3, 2023
Closed
3 tasks
chenlizhong
chenlizhong approved these changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@chenlizhong chenlizhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@wushiqinlou
Copy link
Contributor

This update is good to me

@xiangce xiangce merged commit 7b15f9d into master Aug 3, 2023
7 checks passed
@xiangce xiangce deleted the not_redact_ls_system_units branch August 3, 2023 05:09
xiangce added a commit that referenced this pull request Aug 3, 2023
@xiangce
fix: don't redact ls_systemd_units to avoid issue#3858 (#3870)
5dc4a90 
Signed-off-by: Xiangce Liu <[email protected]>
(cherry picked from commit 7b15f9d)
xiangce added a commit that referenced this pull request Sep 6, 2024
@xiangce
fix: don't redact ls_systemd_units to avoid issue#3858 (#3870)
0c47aef 
Signed-off-by: Xiangce Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenlizhong chenlizhong chenlizhong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The class Directory from ls_parser hits exception for specical directory name
3 participants
@xiangce @wushiqinlou @chenlizhong