Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: add new parser LSlad #4262

Closed
wants to merge 1 commit into from
Closed

Conversation

TZ3070
Copy link
Contributor

@TZ3070 TZ3070 commented Oct 31, 2024

All Pull Requests:

Check all that apply:

  • Have you followed the guidelines in our Contributing document, including the instructions about commit messages?
  • No Sensitive Data in this change?
  • Is this PR to correct an issue?
  • Is this PR an enhancement?

Complete Description of Additions/Changes:

Add new parser LSlad

Signed-off-by: Xinting Li <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 3 lines in your changes missing coverage. Please review.

Project coverage is 77.18%. Comparing base (11209f9) to head (9c4d00d).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
insights/parsers/ls.py 75.00% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4262   +/-   ##
=======================================
  Coverage   77.17%   77.18%           
=======================================
  Files         761      762    +1     
  Lines       41472    41496   +24     
  Branches     8763     8768    +5     
=======================================
+ Hits        32008    32029   +21     
- Misses       8407     8408    +1     
- Partials     1057     1059    +2     
Flag Coverage Δ
unittests 77.17% <83.33%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xiangce xiangce added SPEC Change needs SPEC approval parser labels Nov 4, 2024
Copy link
Contributor

@xiangce xiangce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please file a Jira card for this new spec first. And please check if the local class FileListing can be used as base or not.

@TZ3070
Copy link
Contributor Author

TZ3070 commented Nov 6, 2024

closed the PR, as will be using the ’ls -lan‘ instead.

@TZ3070 TZ3070 closed this Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parser SPEC Change needs SPEC approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants