fix: do not import 'insights.client.constants' in spec_cleaner #4267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiangce
force-pushed
the
cleaner_circular_import
branch
from
707f7f3
to
24aa11a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4267 +/- ##
==========================================
+ Coverage 77.15% 77.18% +0.03%
==========================================
Files 762 762
Lines 41510 41511 +1
Branches 8773 8773
==========================================
+ Hits 32027 32041 +14
+ Misses 8426 8412 -14
- Partials 1057 1058 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
xiangce
force-pushed
the
cleaner_circular_import
branch
2 times, most recently
from
f55716c
to
166fd1c
Compare
- it causes circular import issue when triggering data collection via 'insights-collect' command - instead of importing the constants from insights.client, this change sets the "rhsm_facts_file" to insights_config Signed-off-by: Xiangce Liu <[email protected]> rh-pre-commit.version: 2.3.1 rh-pre-commit.check-secrets: ENABLED
xiangce
force-pushed
the
cleaner_circular_import
branch
from
166fd1c
to
d14250e
Compare
Signed-off-by: Xiangce Liu <[email protected]> rh-pre-commit.version: 2.3.1 rh-pre-commit.check-secrets: ENABLED
JoySnow
approved these changes
Nov 12, 2024
xiangce
added a commit
that referenced
this pull request
Nov 14, 2024
- it causes circular import issue when triggering data collection via 'insights-collect' command - instead of importing the constants from insights.client, this change sets the "rhsm_facts_file" to insights_config Signed-off-by: Xiangce Liu <[email protected]> rh-pre-commit.version: 2.3.1 rh-pre-commit.check-secrets: ENABLED (cherry picked from commit 0e7b8c3)
xiangce
added a commit
that referenced
this pull request
Nov 14, 2024
- it causes circular import issue when triggering data collection via 'insights-collect' command - instead of importing the constants from insights.client, this change sets the "rhsm_facts_file" to insights_config Signed-off-by: Xiangce Liu <[email protected]> rh-pre-commit.version: 2.3.1 rh-pre-commit.check-secrets: ENABLED (cherry picked from commit 0e7b8c3) (cherry picked from commit 8b6c0ca)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
via 'insights-collect' command
this change sets the "rhsm_facts_file" to insights_config
All Pull Requests:
Check all that apply:
Complete Description of Additions/Changes: