Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT: Debug Sonarqube runs #1766

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

DRAFT: Debug Sonarqube runs #1766

wants to merge 1 commit into from

Conversation

strider
Copy link
Contributor

@strider strider commented May 22, 2024

Overview

This PR is being created to address RHINENG-xxxx.
(A description of your PR's changes, along with why/context to the PR, goes here.)

PR Checklist

  • Keep PR title short, ideally under 72 characters
  • Descriptive comments provided in complex code blocks
  • Tests: validate optimal/expected output
  • Tests: validate exceptions and failure scenarios
  • Tests: edge cases
  • Recovers or fails gracefully during potential resource outages (e.g. DB, Kafka)
  • Uses type hinting, if convenient
  • Documentation, if this PR changes the way other services interact with host inventory
  • Links to related PRs

Secure Coding Practices Documentation Reference

You can find documentation on this checklist here.

Secure Coding Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

Sorry, something went wrong.

@strider strider requested a review from a team as a code owner May 22, 2024 13:54

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Signed-off-by: Gaël Chamoulaud <[email protected]>
@strider
Copy link
Contributor Author

strider commented May 22, 2024

/retest

@roliveri
Copy link
Contributor

Is this broken because the secrets need to be updated in Vault, or because the shell script no longer corresponds to the runtime environment? Does it have to be migrated to the new Sonarqube endpoint? Do we know?

@kruai
Copy link
Collaborator

kruai commented Nov 21, 2024

@strider Do you still need this PR, or can we close it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants