-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Fix flaky HybridInventory.cy.js test #2243
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2243 +/- ##
=======================================
Coverage 58.69% 58.69%
=======================================
Files 198 198
Lines 5239 5239
Branches 1912 1912
=======================================
Hits 3075 3075
Misses 2164 2164 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should not we fix passing data-ouia-safe
to InventoryTable or give it a default value instead?
@mkholjuraev, it's not an easy task to program |
12b8304
to
f10aafa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
We don't pass
data-ouia-safe
to InventoryTable and it's set to true by default. Though, in the flaky test, for some reason,data-ouia-safe
was missing completely, which makes this attribute somewhat unreliable to use: https://app.travis-ci.com/github/RedHatInsights/insights-inventory-frontend/jobs/625131895#L6568. HybridInventory.cy.test should use other way to indicate the table readiness.