Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tests): Update coverage config #2251

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bastilian
Copy link
Member

No description provided.

@bastilian bastilian force-pushed the update_coverage_config branch from 0a6756a to d359ef2 Compare September 19, 2024 01:30
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.36%. Comparing base (070d6d2) to head (d359ef2).
Report is 4 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2251       +/-   ##
===========================================
+ Coverage   59.08%   76.36%   +17.28%     
===========================================
  Files         202      202               
  Lines        5299     5298        -1     
  Branches     1918     1917        -1     
===========================================
+ Hits         3131     4046      +915     
+ Misses       2168     1252      -916     
Flag Coverage Δ
combined 76.36% <ø> (?)
cypress 66.02% <ø> (?)
jest 59.17% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines +55 to +56
stream: require.resolve('stream-browserify'),
zlib: require.resolve('browserify-zlib'),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you provide a brief background on why this is added?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just took what was in compliance configured. I'll try and see if and why this would be required.

@gkarat
Copy link
Contributor

gkarat commented Sep 19, 2024

With the current changes, I can see that the coverage reports are generated fine 👍 and it looks like both cypress and jest tests are included in the coverage. I think this can be moved from draft to ready to review if you wish

@bastilian
Copy link
Member Author

@gkarat I want to wait for RedHatInsights/frontend-components#2066 to be merged, as react-intl should not be a direct dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants