-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(tests): Update coverage config #2251
base: master
Are you sure you want to change the base?
Conversation
0a6756a
to
d359ef2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2251 +/- ##
===========================================
+ Coverage 59.08% 76.36% +17.28%
===========================================
Files 202 202
Lines 5299 5298 -1
Branches 1918 1917 -1
===========================================
+ Hits 3131 4046 +915
+ Misses 2168 1252 -916
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
stream: require.resolve('stream-browserify'), | ||
zlib: require.resolve('browserify-zlib'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you provide a brief background on why this is added?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just took what was in compliance configured. I'll try and see if and why this would be required.
With the current changes, I can see that the coverage reports are generated fine 👍 and it looks like both cypress and jest tests are included in the coverage. I think this can be moved from draft to ready to review if you wish |
@gkarat I want to wait for RedHatInsights/frontend-components#2066 to be merged, as |
No description provided.