Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for metrics URL settign and checking #285

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ddonahue007
Copy link

@ddonahue007 ddonahue007 commented Apr 1, 2024

This PR changes the following:

  • add ability to change scheme for METRICS_PUSH_GATEWAY

  • move enable metrics log message
    The following is seen in the logs even when metrics is disabled:

{"level":30,"time":1711990810254,"pid":1,"hostname":"remediations-consumer-cleaner-28533180-mlrfg","name":"remediations-consumer","type":"application","msg":"metrics sent","v":1}

The change is to move the log message, logging the above only when metrics are truly sent, and when pushing metrics is false, log a message to that effect.

add ability to change protocol if nessary
@ddonahue007 ddonahue007 requested a review from rexwhite as a code owner April 1, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant