Add Kafka message to success log messages #307
Conversation
marleystipich2
force-pushed
the
add-kafka-message-debug
branch
2 times, most recently
from
ca512c9 to
6229f74
Compare
| @@ -46,6 +46,7 @@ const counters = { | |||
|
|
|||
| export function incomingMessage (topic: string, message: Message) { | |||
| log.trace({ message }, 'incoming message'); | |||
| log.info({ message }, 'incoming message'); | |||
There was a problem hiding this comment.
I can't figure out where to see the trace log messages but this would be a helpful one to see in the logs too so adding an info log message.
There was a problem hiding this comment.
'trace' is a logging level. It's set in deployment/remediations-consumer-clowdapp.yaml but can be overridden in the app-interface config (it's currently set to 'info'). There's also a config parameter that controls kafaka logging, which appears to be disabled so we might want to turn that on in stage to see what we get. 🙂
marleystipich2
force-pushed
the
add-kafka-message-debug
branch
2 times, most recently
from
1f99a0f to
4696ec3
Compare
|
/retest |
marleystipich2
force-pushed
the
add-kafka-message-debug
branch
from
4696ec3 to
ffc7f68
Compare
marleystipich2
force-pushed
the
add-kafka-message-debug
branch
from
ffc7f68 to
e9e6471
Compare
|
/retest |
| @@ -46,6 +46,7 @@ const counters = { | |||
|
|
|||
| export function incomingMessage (topic: string, message: Message) { | |||
| log.trace({ message }, 'incoming message'); | |||
| log.info({ message }, 'incoming message'); | |||
There was a problem hiding this comment.
'trace' is a logging level. It's set in deployment/remediations-consumer-clowdapp.yaml but can be overridden in the app-interface config (it's currently set to 'info'). There's also a config parameter that controls kafaka logging, which appears to be disabled so we might want to turn that on in stage to see what we get. 🙂
I think this would help a lot with debugging and understanding the kafka messages more.
Secure Coding Practices Checklist GitHub Link