-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update go version to 1.22 #267
Update go version to 1.22 #267
Conversation
I am not linking the RHINENG-5181 to the pull request as the bugzilla attached to this ticket is not yet resolved with the Errata. |
6ffdc46
to
89e84b3
Compare
@upadhyeammit Shall we look around for some other image? I would like to check if there is a possibility to go for 1.22 or 1.23 atm. |
/retest |
02fb92d
to
354129b
Compare
go.mod
Outdated
@@ -1,78 +1,87 @@ | |||
module github.com/redhatinsights/ros-ocp-backend | |||
|
|||
go 1.20 | |||
go 1.22.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@upadhyeammit I think it is better to avoid the minor version here, since we don't seem to have that granularity in the Dockerfile tag, thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah.. actually its kind of like if we run the go mod tidy then it adds the minor version, updated it
@upadhyeammit Let's update the version here as well. |
354129b
to
2c61cf8
Compare
added already |
Its weird, if we remove the minor version then linting fails,
|
as its failing https://github.com/RedHatInsights/ros-ocp-backend/actions/runs/11835786586/job/32979299087?pr=267 . I am repushing with minor version |
edfd317
to
c3a160d
Compare
@upadhyeammit I see that the image has 1.22.7 so we could do something like this and
I also noticed, that the minor versions don't change in the images by looking the previous tags. |
I tried it and now I can see
|
c3a160d
to
7717b24
Compare
/retest |
7717b24
to
fe98ffb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@upadhyeammit Thanks for the changes 👍🏼
PR Title 💥
Please title this PR with a summary of the change, along with the JIRA card number.
Suggested formats:
Feel free to remove this section from PR description once done.
Why do we need this change? 💭
Please include the context of this change here. If the change depends on Kruize add details about that as well!
Documentation update? 📝
Security Checklist 🔒
Upon raising this PR please go through RedHatInsights/secure-coding-checklist
💂♂️ Checklist 🎯
Additional 📣
Feel free to add any other relevant details such as links, notes, screenshots, here.