RHCLOUD-35843 | refactor: Sources' REST API client #102
+283
−254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikelAlejoBR
force-pushed
the
RHCLOUD-35843-refactor-superkey-rest-api-client
branch
2 times, most recently
from
735e8c9 to
1f2bba6
Compare
The REST API functions that were being used were almost a copy paste of one another, which made following the code difficult. The goal of the refactor was to simplify the code and make it easier to follow and reason about. Also, it introduces a timeout for the requests by default, which could be the cause for which the Superkey struggles so much and ends up restarting non-stop. Another goal of this refactor was to leave everything in an state where it is easier to reason about how the Superkey worker should be refactored further, like introducing proper dependency injection and untangling the resource making from the "ForgeApplication" struct. However, that's for another PR. RHCLOUD-35843
MikelAlejoBR
force-pushed
the
RHCLOUD-35843-refactor-superkey-rest-api-client
branch
from
1f2bba6 to
07cce82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The REST API functions that were being used were almost a copy paste of
one another, which made following the code difficult.
The goal of the refactor was to simplify the code and make it easier to
follow and reason about. Also, it introduces a timeout for the requests
by default, which could be the cause for which the Superkey struggles so
much and ends up restarting non-stop.
Another goal of this refactor was to leave everything in an state where
it is easier to reason about how the Superkey worker should be
refactored further, like introducing proper dependency injection and
untangling the resource making from the "ForgeApplication" struct.
However, that's for another PR.
Dependency
Jira ticket
[RHCLOUD-35843]