fix: Fix known exploit label always being compact (#1539)

* fix: Fix known exploit label always being compact * Update snapshot
RedHatInsights · Feb 9, 2022 · b37cdce · b37cdce
1 parent a438224
commit b37cdce
Show file tree

Hide file tree

Showing 6 changed files with 10 additions and 12 deletions.
diff --git a/...esentationalComponents/KnownExploitSummary/__snapshots__/KnownExploitSummary.test.js.snap b/...esentationalComponents/KnownExploitSummary/__snapshots__/KnownExploitSummary.test.js.snap
@@ -205,7 +205,6 @@ exports[`KnownExploitSummary component Should match snapshot. 1`] = `
                                         ]
                                       }
                                       color="red"
-                                      isCompact={true}
                                       style={Object {}}
                                     >
                                       <Memo(MemoizedFormattedMessage)
@@ -228,11 +227,10 @@ exports[`KnownExploitSummary component Should match snapshot. 1`] = `
                                         ]
                                       }
                                       color="red"
-                                      isCompact={true}
                                       style={Object {}}
                                     >
                                       <span
-                                        className="pf-c-label pf-m-red pf-m-compact cve-labels pf-u-mr-sm"
+                                        className="pf-c-label pf-m-red cve-labels pf-u-mr-sm"
                                         style={Object {}}
                                       >
                                         <span

diff --git a/src/Components/PresentationalComponents/Snippets/GroupedCVELabels.js b/src/Components/PresentationalComponents/Snippets/GroupedCVELabels.js
@@ -6,7 +6,7 @@ import CSAwLabel from './CSAwLabel';
 
 const GroupedCVELabels = ({ hasExploit, hasRule, isCompact }) =>
     (hasExploit || hasRule) && (
-        <LabelGroup className="pf-u-mt-xs cve-labels-grouped--nowrap">
+        <LabelGroup className="cve-labels-grouped--nowrap">
             {hasExploit && <KnownExploitLabel isCompact={isCompact}/>}
             {hasRule && <CSAwLabel isCompact={isCompact}/>}
         </LabelGroup>

diff --git a/src/Components/PresentationalComponents/Snippets/KnownExploitLabel.js b/src/Components/PresentationalComponents/Snippets/KnownExploitLabel.js
@@ -4,17 +4,18 @@ import PropTypes from 'prop-types';
 import { FormattedMessage } from 'react-intl';
 import messages from '../../../Messages';
 
-const KnownExploitLabel = ({ style, className }) => (
+const KnownExploitLabel = ({ style, className, isCompact }) => (
     <Tooltip content={<FormattedMessage {...messages.knownExploitDescription} />}>
-        <Label color="red" style={{ ...style }} className={['cve-labels', className]} isCompact>
+        <Label color="red" style={{ ...style }} className={['cve-labels', className]} isCompact={isCompact}>
             <FormattedMessage {...messages.knownExploit} />
         </Label>
     </Tooltip>
 );
 
 KnownExploitLabel.propTypes = {
     style: PropTypes.object,
-    className: PropTypes.string
+    className: PropTypes.string,
+    isCompact: PropTypes.bool
 };
 
 export default KnownExploitLabel;
diff --git a/src/Components/PresentationalComponents/Snippets/Label.scss b/src/Components/PresentationalComponents/Snippets/Label.scss
@@ -13,4 +13,5 @@ span {
 
 .cve-labels-grouped--nowrap {
     flex-wrap: nowrap;
+    margin-top: 2px;
 }
diff --git a/...Components/PresentationalComponents/Snippets/__snapshots__/KnownExploitLabel.test.js.snap b/...Components/PresentationalComponents/Snippets/__snapshots__/KnownExploitLabel.test.js.snap
@@ -113,7 +113,6 @@ exports[`KnownExploitLabel component Should match snapshot 1`] = `
                   ]
                 }
                 color="red"
-                isCompact={true}
                 style={Object {}}
               >
                 <Memo(MemoizedFormattedMessage)
@@ -136,11 +135,10 @@ exports[`KnownExploitLabel component Should match snapshot 1`] = `
                   ]
                 }
                 color="red"
-                isCompact={true}
                 style={Object {}}
               >
                 <span
-                  className="pf-c-label pf-m-red pf-m-compact cve-labels"
+                  className="pf-c-label pf-m-red cve-labels"
                   style={Object {}}
                 >
                   <span

diff --git a/src/Components/SmartComponents/SystemCves/__snapshots__/SystemCvesTable.test.js.snap b/src/Components/SmartComponents/SystemCves/__snapshots__/SystemCvesTable.test.js.snap
@@ -7058,7 +7058,7 @@ exports[`SystemCvesTable Should match snapshots 1`] = `
                                                     <LabelGroup
                                                       aria-label="Label group category"
                                                       categoryName=""
-                                                      className="pf-u-mt-xs cve-labels-grouped--nowrap"
+                                                      className="cve-labels-grouped--nowrap"
                                                       closeBtnAriaLabel="Close label group"
                                                       collapsedText="\${remaining} more"
                                                       defaultIsOpen={false}
@@ -7076,7 +7076,7 @@ exports[`SystemCvesTable Should match snapshots 1`] = `
                                                         prefix="pf-random-id-"
                                                       >
                                                         <div
-                                                          className="pf-c-label-group pf-u-mt-xs cve-labels-grouped--nowrap"
+                                                          className="pf-c-label-group cve-labels-grouped--nowrap"
                                                         >
                                                           <div
                                                             className="pf-c-label-group__main"