fix(RHINENG-12310): Tag filter error on Reports page #2166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2166 +/- ##
==========================================
+ Coverage 67.07% 67.22% +0.15%
==========================================
Files 129 129
Lines 3468 3469 +1
Branches 1077 1078 +1
==========================================
+ Hits 2326 2332 +6
+ Misses 1142 1137 -5 ☔ View full report in Codecov by Sentry. |
johnsonm325
force-pushed
the
rhineng-12310
branch
from
422efdf to
4706555
Compare
To reproduce: Go to https://console.redhat.com/insights/vulnerability/cves At top in 'Filter by tag' select a value with systems Navigate to https://console.redhat.com/insights/vulnerability/reports#SIDs=&tags= Select Create report Error is displayed The issue is that the `useSelector` on ReportsPage was not putting the tags into an array, AND if there were no tags, then it wasn't returning an empty array properly. Make sure to apply multiple variations of workloads, SAP IDs, and tags to make sure this feature works correctly.
johnsonm325
force-pushed
the
rhineng-12310
branch
from
4706555 to
4923367
Compare
|
Commits missing Jira IDs: |
adonispuente
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To reproduce:
The issue is that the
useSelectoron ReportsPage was not putting the tags into an array, AND if there were no tags, then it wasn't returning an empty array properly.Make sure to apply multiple variations of workloads, SAP IDs, and tags to make sure this feature works correctly.