Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(RHINENG-12933): change CVE status column style #2179

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xmicha82
Copy link
Contributor

Change CVE status columns to align with mocks in RHINENG-12933

Before

System Detail Page

image

CVEs Table

image

CVE Detail Page

image

After

System Detail Page

image

CVEs Table

image
image

CVE Detail Page

image

@xmicha82 xmicha82 requested a review from a team as a code owner December 12, 2024 15:01
Copy link

jira-linking bot commented Dec 12, 2024

Referenced Jiras:
https://issues.redhat.com/browse/RHINENG-12933

@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 67.19%. Comparing base (bb575d9) to head (01502d3).

Files with missing lines Patch % Lines
src/Helpers/constants.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2179      +/-   ##
==========================================
+ Coverage   67.11%   67.19%   +0.07%     
==========================================
  Files         129      130       +1     
  Lines        3473     3481       +8     
  Branches     1104     1106       +2     
==========================================
+ Hits         2331     2339       +8     
  Misses       1142     1142              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@leSamo leSamo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks suuuuuuuper nice. I have a bit of a problem with the System detail view since it removes some information, but this is not a problem with the PR, but rather the mockups, I will add some comments there.

src/Helpers/constants.js Outdated Show resolved Hide resolved
@leSamo
Copy link
Member

leSamo commented Dec 13, 2024

Also the "Applies to this specific system" icon should probably be on the same line.

image

@xmicha82 xmicha82 force-pushed the cve-status branch 6 times, most recently from 9e2171f to 2f2b3da Compare January 8, 2025 14:18
@xmicha82
Copy link
Contributor Author

xmicha82 commented Jan 8, 2025

/retest

1 similar comment
@xmicha82
Copy link
Contributor Author

xmicha82 commented Jan 9, 2025

/retest

@LightOfHeaven1994
Copy link
Contributor

@xmicha82 PR is good for review, ignore these 2 red pipelines that has bonfire name in it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants