fix(RHINENG-13688): Convert publish date filter to select #2181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Referenced Jiras: |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2181 +/- ##
==========================================
- Coverage 67.11% 67.07% -0.05%
==========================================
Files 129 129
Lines 3473 3468 -5
Branches 1104 1104
==========================================
- Hits 2331 2326 -5
Misses 1142 1142 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
@johnsonm325 generally looks good, but I think we need to fix
We don't need to show Publish date: filter name here
but I know there is another place where we need to show it (this is correct)
This PR removes the radios from the publish date filter dropdown on the CVEs table toolbar. It implements the custom Select filter that was created for the Create Report modal. The publish date filter on the CVEs table does not include the "All" option. In order to get all publish dates, a user must remove any applied publish date filter. The Create Report modal, on the other hand, does include the "All" option because there is no way for a user to remove a publish date filter if one is applied.
johnsonm325
force-pushed
the
rhineng-13688
branch
from
cb9a966 to
d489d8d
Compare
|
@LightOfHeaven1994 good find. Should be fixed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the radios from the publish date filter dropdown on the CVEs table toolbar. It implements the custom Select filter that was created for the Create Report modal.
The publish date filter on the CVEs table does not include the "All" option. In order to get all publish dates, a user must remove any applied publish date filter.
The Create Report modal, on the other hand, does include the "All" option because there is no way for a user to remove a publish date filter if one is applied.