fix commit message check #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r14chandra
reviewed
Sep 8, 2023
| pattern: '^(Refs|Fixes) #YUPTOO-[0-9]+ - .+$' | ||
| error: 'Commit message should start with "Fixes #YUPTOO-<issue number> - "' | ||
| pattern: '^(Refs|Fixes) #RHINENG-[0-9]+ - .+$' | ||
| error: 'Commit message should start with "Fixes #RHINENG-<issue number> - "' |
There was a problem hiding this comment.
I just feel RHINENG-XXX should be fine as a prefix rather than adding Fixes or Refs #.
It is just my thought. Feel free to add your suggestions.
There was a problem hiding this comment.
I will modify the pattern that will accept without these prefix Fixes/Refs as well.
r14chandra
approved these changes
Sep 8, 2023
|
Your commit doesn't contain the JIRA card number. Tests are failing due to that. |
kgaikwad
force-pushed
the
modify_commit_check
branch
from
1277835 to
1712468
Compare
Codecov ReportPatch has no changes to coverable lines. 📢 Thoughts on this report? Let us know!. |
kgaikwad
force-pushed
the
modify_commit_check
branch
from
1712468 to
f3723ab
Compare
|
\retest |
kgaikwad
force-pushed
the
modify_commit_check
branch
from
f3723ab to
93fb677
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.