Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHINENG-5922 support multiple kafka brokers #69

Merged
merged 2 commits into from
Jan 3, 2024

Conversation

r14chandra
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Dec 15, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (3d5ef0d) 78.79% compared to head (a98b125) 78.79%.

Files Patch % Lines
yuptoo/lib/config.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #69   +/-   ##
=======================================
  Coverage   78.79%   78.79%           
=======================================
  Files          23       23           
  Lines         613      613           
=======================================
  Hits          483      483           
  Misses        130      130           
Flag Coverage Δ
unittests 78.79% <50.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@kgaikwad kgaikwad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@r14chandra , just a small suggestion added on PR.
As it includes multiple constant variables when it comes to local development. Could you update it?

yuptoo/lib/config.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@kgaikwad kgaikwad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thank you @r14chandra! Merging it.

@kgaikwad kgaikwad merged commit 66e92f1 into RedHatInsights:main Jan 3, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants