Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: moves regeneration tasks to workflow location where the diff c… #80

Merged
merged 5 commits into from
Mar 13, 2024

Conversation

jpower432
Copy link
Member

…an be utilized

What

Add regeneration to transform rules and update profiles workflows.

Why

  • transform-rules: Regeneration to ensure the rule changes are propagated to the markdown before assembly
  • update-profiles: Allow the control diff to be viewed in the markdown before merge to better understand how impact of the changes

@jpower432 jpower432 requested a review from a team as a code owner March 6, 2024 21:27
Copy link
Contributor

github-actions bot commented Mar 6, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 2 0 0.01s
✅ REPOSITORY gitleaks yes no 12.46s
✅ REPOSITORY kics yes no 23.24s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

Copy link

@beatrizmcouto beatrizmcouto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Information moved around, lgtm

@jpower432
Copy link
Member Author

@beatrizmcouto After more testing, moving this back into draft to rework.

@jpower432 jpower432 marked this pull request as draft March 12, 2024 20:36
@jpower432 jpower432 marked this pull request as ready for review March 12, 2024 21:25
Copy link

@beatrizmcouto beatrizmcouto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved tasks LGTM

@jpower432 jpower432 merged commit 029f226 into main Mar 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants