Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: updates README.md with Getting Started and design info #91

Merged
merged 3 commits into from
May 23, 2024

Conversation

jpower432
Copy link
Member

@jpower432 jpower432 commented May 20, 2024

Updates docs to use the same structure as oscal-component-definitions. This replaces the manual tutorial (which is out of date) with a tutorial about how to interact with the repostiroy content through GitHub and trestle-bot actions. In depth approach information (like https://github.com/RedHatProductSecurity/oscal-component-definitions/blob/main/docs/design.md) is also added.

Testing CI naming changes

README.md Outdated
The workflow to update content consists of the following steps:

1. From a user's branch, modify and commit a markdown or json file within the workspace. (Most updates will be made to markdown files.)
2. A user submits a pull request to add their changes to the workspace's master branch.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest replacing master with main to align with step 4.

docs/design.md Outdated

The `create-new` workflow is triggered manually by going to the Action tab. This creates a new OSCAL profile in the trestle workspace. A new branch is created and a pull request is opened.

#### AutoFix
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it ease understanding if this was titled "AutoSync" to align with the trestle-bot terminology?

@jpower432 jpower432 requested a review from gvauter May 22, 2024 18:59
@jpower432
Copy link
Member Author

@gvauter Please take another look. Due to changes in the CI files, this might require some testing on my fork as well.

Copy link
Member

@gvauter gvauter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpower432 jpower432 merged commit 0969fd9 into RedHatProductSecurity:main May 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants