Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add unit tests for missed code paths #126

Merged
merged 4 commits into from
Jan 2, 2024
Merged

test: add unit tests for missed code paths #126

merged 4 commits into from
Jan 2, 2024

Conversation

jpower432
Copy link
Member

@jpower432 jpower432 commented Dec 15, 2023 •
edited
Loading

Description

Identified missed paths on new code in SonarClould report.

This PR adds tests to covered those missed paths.

Type of change

  • Tests only

How has this been tested?

N/A

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@jpower432 jpower432 changed the title testadd types unit tests test: add unit tests in test_types and test_entrypoint_base Dec 15, 2023
@jpower432 jpower432 changed the title test: add unit tests in test_types and test_entrypoint_base test: add unit tests for missed code paths Dec 15, 2023
@jpower432 jpower432 marked this pull request as ready for review December 15, 2023 20:15
beatrizmcouto
beatrizmcouto approved these changes Dec 29, 2023
View reviewed changes
Copy link
Contributor

@beatrizmcouto beatrizmcouto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed at a high level, no specific questions here

@jpower432 jpower432 merged commit c6b5b49 into main Jan 2, 2024
16 checks passed
@jpower432 jpower432 deleted the chore/add-types-unit-tests branch February 15, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beatrizmcouto beatrizmcouto beatrizmcouto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpower432 @beatrizmcouto