Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/add outputs #13

Merged
merged 4 commits into from
Jun 28, 2023
Merged

Conversation

jpower432
Copy link
Member

@jpower432 jpower432 commented Jun 28, 2023

Description

Adds changes to support outputs for the Action

  • Print commit sha before CLI exits
  • Updates entrypoint script
  • Update bot return value

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How has this been tested?

  • Unit tests added/updates
  • Manual test (steps below)
podman build -f Dockerfile -t localhost:5000/trestlebot:latest
# The below command should simulate how GitHub Action would run this
podman run --entrypoint /entrypoint.sh -e INPUT_WORKING_DIR="." -e "INPUT_BRANCH=test" -e "INPUT_MARKDOWN_PATH=markdown/profiles" -e "INPUT_ASSEMBLE_MODEL=profile" -e INPUT_SSP_INDEX_PATH="" -e INPUT_COMMIT_MESSAGE="" -e INPUT_COMMIT_USER_NAME="me" -e INPUT_COMMIT_USER_EMAIL="[email protected]" -e INPUT_FILE_PATTERN=*.json -e INPUT_COMMIT_AUTHOR_NAME="" -e INPUT_COMMIT_AUTHOR_EMAIL=""  -v <path to repo>:/data -w /data localhost:5000/trestlebot:latest

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@jpower432 jpower432 marked this pull request as draft June 28, 2023 17:38
@jpower432 jpower432 requested a review from afflom June 28, 2023 17:40
@jpower432 jpower432 marked this pull request as ready for review June 28, 2023 18:21
@afflom afflom merged commit 25d2cc8 into RedHatProductSecurity:main Jun 28, 2023
6 checks passed
@jpower432 jpower432 deleted the feat/add-outputs branch August 3, 2023 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants