PSCE-309 - Adds sync-upstreams GitHub Action and usage documentation #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpower432
force-pushed
the
PSCE-309
branch
2 times, most recently
from
eeaa651
to
79645dd
Compare
To reduce code duplication in the bash script, common logic is added to common.sh for reuse. Signed-off-by: Jennifer Power <[email protected]>
Signed-off-by: Jennifer Power <[email protected]>
The working directory is subject to change and the entrypoint scripts need to source `common.sh` from the location in the container. Signed-off-by: Jennifer Power <[email protected]>
| @@ -104,7 +105,40 @@ jobs: | |||
| branch: ${{ github.head_ref }} | |||
| ``` | |||
|
|
|||
| ## Component Regeneration | |||
| ## Propagate Changes from upstream sources | |||
|
|
|||
There was a problem hiding this comment.
Minor suggestions - change te word "Changes" to start with a lowercase c
actions/sync-upstreams/README.md
Outdated
There was a problem hiding this comment.
Minor suggestions and uppercase T in "trestlebot"
beatrizmcouto
approved these changes
Jan 17, 2024
Signed-off-by: Jennifer Power <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
sync-upstreamsGitHub Action and documentation on usage.Review Hints
The first commit adds
common.shreduce some of the duplicate logic in the entrypoint bash scripts to prepare to add a fourth script.Stacked with #142
Rationale
common.shfile - There was about ~39 lines of duplicated logic per file so before adding another file with duplicated, I add that logic to a common file that will just store reusable functions.Type of change
How has this been tested?
- Working with comma separation - https://github.com/jpower432/cautious-potato/actions/runs/7508213824
- Newline separation - https://github.com/jpower432/cautious-potato/actions/runs/7530774759/job/20497901679
- create-cd - https://github.com/jpower432/cautious-potato/actions/runs/7507909168
- transform-rules - https://github.com/jpower432/cautious-potato/actions/runs/7508129092/job/20443009052
- autosync - https://github.com/jpower432/cautious-potato/actions/runs/7508168427/job/20443116558
Checklist