Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: removes markdown creation from create_new_with_filter #159

Merged
merged 2 commits into from
Jan 31, 2024
Merged

chore: removes markdown creation from create_new_with_filter #159

merged 2 commits into from
Jan 31, 2024

Conversation

jpower432
Copy link
Member

Description

Removing unused portions of this function.
The SSP filter functionality is meant for reporting purposes and not for editing currently.

Type of change

  • Cleanup/Refactor

How has this been tested?

  • Unit tests updated

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@jpower432
chore: removes markdown creation from create_new_with_filter
3958ef1 
Removing unused portions of this function. The SSP filter
funtionality is meant for reporting purposes only and not
for editing.

Signed-off-by: Jennifer Power <[email protected]>
@jpower432 jpower432 marked this pull request as ready for review January 30, 2024 22:10
beatrizmcouto
beatrizmcouto approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@beatrizmcouto beatrizmcouto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small changes removing markdown creation related code, LGTM

@jpower432 jpower432 merged commit 982ba32 into main Jan 31, 2024
11 checks passed
@jpower432 jpower432 deleted the chore/remove-unused-ssp-code branch January 31, 2024 17:31
@github-actions github-actions bot mentioned this pull request Sep 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beatrizmcouto beatrizmcouto beatrizmcouto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpower432 @beatrizmcouto