-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: adds a E2ETestRunner for E2E tests #177
Conversation
4f68b7e
to
f26a7c7
Compare
… E2E tests Signed-off-by: Jennifer Power <[email protected]>
The negative test case exit codes and output can be easily verified through unit test and should not change when not running in a container. Saving E2E to verify functionality inside a container environment. Signed-off-by: Jennifer Power <[email protected]>
e0e4923
to
1662bfa
Compare
For clarity, reference class variables by the class name Signed-off-by: Jennifer Power <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @jpower432 just wanted to understand the reasoning behind changing to a use a single class and fixture instead of a collection of functions. Both work but single class makes the code cleaner, is that is or another reasoning behind it? Thank you
@beatrizmcouto Great question! A few reasons behind this change from my perspective:
|
@JimFuller-RedHat PTAL. Relates to a comment you had on #158. |
Description
Update E2E test code to use a single class and fixture instead of a collection of functions.
Also removes negative test cases (which test specific failures and logging statements) that don't need to be tested in the container to the unit tests from the e2e tests.
Fixes #166
Type of change
How has this been tested?
Checklist