Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adds OSCAL validated component definition types to create-cd #191

Merged
merged 3 commits into from
Mar 20, 2024

Conversation

jpower432
Copy link
Member

@jpower432 jpower432 commented Mar 19, 2024

Description

Adds all valid types per the OSCAL constraints for component definition types to the choices list.

Fixes #190

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How has this been tested?

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@jpower432 jpower432 marked this pull request as ready for review March 19, 2024 21:05
Copy link
Contributor

@beatrizmcouto beatrizmcouto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding component definition types, approved

@jpower432 jpower432 merged commit 393fd85 into main Mar 20, 2024
11 checks passed
@jpower432 jpower432 deleted the bug/compdef-types branch March 27, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Command create-cd does not support all of the component definition types defined in the OSCAL schema
2 participants