Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: improves readability of the SSP end to end tests #198

Merged
merged 4 commits into from
Mar 28, 2024
Merged

refactor: improves readability of the SSP end to end tests #198

merged 4 commits into from
Mar 28, 2024

Conversation

jpower432
Copy link
Member

@jpower432 jpower432 commented Mar 25, 2024 •
edited
Loading

Description

  • Improve readability of test_e2e_ssp.py
  • Remove missed subprocess line
  • Checks output on intentional E2E failures

Type of change

  • Bug fix (non-breaking change which fixes an issue) refactor/bug-fix

How has this been tested?

  • Run locally and in CI

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@jpower432
refactor: refines E2E ssp test for better readabilty
6836762 
Remove the redefinition of commands that would create the
same output and removed missed subprocess line

Signed-off-by: Jennifer Power <[email protected]>
@jpower432
refactor: improves readabilty of SSP E2E testing and tests error mess…
bf6314d 
…ages

Signed-off-by: Jennifer Power <[email protected]>
@jpower432 jpower432 added the maintenance Maintenance tasks and refactors label Mar 25, 2024
beatrizmcouto
beatrizmcouto approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@beatrizmcouto beatrizmcouto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as discussed during 1:1 earlier today

@jpower432 jpower432 merged commit 39c6b52 into main Mar 28, 2024
11 checks passed
@jpower432 jpower432 deleted the fix/e2e-errors branch March 29, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beatrizmcouto beatrizmcouto beatrizmcouto approved these changes

Assignees
No one assigned
Labels
maintenance Maintenance tasks and refactors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpower432 @beatrizmcouto